[Facing issue with skipRows]

[shrineeraj]

Describe the bug
Issue in skipRows with header=true strictColumnHandling: true,maxRows:some_number

Parsing or Formatting?

• Formatting
• [Parsing ] Parsing

To Reproduce
Steps to reproduce the behavior:

const csv = require('@fast-csv/parse');
	const rows = [
    'header1,header2\n',
    'col1\n',
    'col2,col2\n',
    'col3\n',
    'col4,col4\n',
    'col5,col5\n',
    'col6,col6\n',
];
const stream = csv
		.parse({ headers: true, skipRows: 2 ,strictColumnHandling: true,maxRows:4
		})
		.on('error', error => console.error(error))
		.on('data-invalid', (row, rowNumber) => {
			console.log(`Invalid [rowNumber=${rowNumber}] [row=${JSON.stringify(row)}]`);
		})
		 .on('data', row => console.log(`valid ${JSON.stringify(row)}`))
		.on('end', rowCount => console.log(`Parsed ${rowCount} rows`));
	rows.forEach(row => stream.write(row));
	stream.end();

Expected behavior
i am accepting the output like this
Invalid [rowNumber=1] [row=["col3"]]
valid {"header1":"col4","header2":"col4"}
valid {"header1":"col5","header2":"col5"}
valid {"header1":"col6","header2":"col6"}
Parsed 4 rows

but actual output given is
Invalid [rowNumber=1] [row=["col1"]]
Invalid [rowNumber=2] [row=["col3"]]
valid {"header1":"col4","header2":"col4"}
valid {"header1":"col5","header2":"col5"}
Parsed 4 rows

Desktop (please complete the following information):

• OS: [WINDOW 10]
• OS Version [e.g. Mojave]
• Node Version [9.3.0]

Additional context
i am executing your code of skip_rows.examples.js with some modifications strictColumnHandling: true and maxRows:some_number. i am doing wrong or it's there an issue

[doug-martin]

Thank you for the great example to reproduce!

This fix will be in v4.0.3

[doug-martin]

published!

[shrineeraj]

thanx

…

On Fri, Feb 14, 2020 at 8:35 AM Doug Martin ***@***.***> wrote: published! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#317?email_source=notifications&email_token=AI5CVRT5LPSZ7OX3MQ4NQILRCYC7HA5CNFSM4KF43HSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELXM5ZQ#issuecomment-586075878>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI5CVRVYJSNVNDPSOT7J6JTRCYC7HANCNFSM4KF43HSA> .

[shrineeraj]

sorry to say but i am getting the same out put as given previously. i am just using your skip_rows.example.js (fast-csv/examples/parsing-js/examples) file with some modification but not getting the desired out
i am accepting the output like this
Invalid [rowNumber=1] [row=["col3"]]
valid {"header1":"col4","header2":"col4"}
valid {"header1":"col5","header2":"col5"}
valid {"header1":"col6","header2":"col6"

[shrineeraj]

sorry to say but i am getting the same out put as given previously. i am just using your skip_rows.example.js (fast-csv/examples/parsing-js/examples) file with some modification but not getting the desired out i am accepting the output like this Invalid [rowNumber=1] [row=["col3"]] valid {"header1":"col4","header2":"col4"} valid {"header1":"col5","header2":"col5"} valid {"header1":"col6","header2":"col6" [image: image.png] On Fri, Feb 14, 2020 at 10:30 AM Neeraj Shrivastava <[email protected]> wrote:

…

thanx On Fri, Feb 14, 2020 at 8:35 AM Doug Martin ***@***.***> wrote: > published! > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#317?email_source=notifications&email_token=AI5CVRT5LPSZ7OX3MQ4NQILRCYC7HA5CNFSM4KF43HSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELXM5ZQ#issuecomment-586075878>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AI5CVRVYJSNVNDPSOT7J6JTRCYC7HANCNFSM4KF43HSA> > . >