Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Enhance documentation around importing the module. #301

Closed
doug-martin opened this issue Dec 19, 2019 · 1 comment
Closed

[FEATURE] Enhance documentation around importing the module. #301

doug-martin opened this issue Dec 19, 2019 · 1 comment
Assignees
@doug-martin @dustinsmith1024
Labels
documentation enhancement in release When a feature is merged in to the release branch
Milestone
v3.7.0

Comments

@doug-martin
Copy link
Contributor

Currently all examples are JS centric, when the module is written in typescript.

This enhancement is focused on how to import the module. In v3.5.0 the esModuleInterop flag was broken when importing fast-csv, however there is no documentation around how to import fast-csv in typescipt. Issue #299 pointed this out.
@doug-martin doug-martin mentioned this issue Dec 19, 2019
Closed
@doug-martin doug-martin added this to the v3.7.0 milestone Dec 19, 2019
doug-martin added a commit that referenced this issue Dec 19, 2019
@doug-martin
Added import/require example #301
5f9281e
@doug-martin doug-martin mentioned this issue Dec 19, 2019
Merged
doug-martin added a commit that referenced this issue Dec 19, 2019
@doug-martin
Merge pull request #303 from C2FO/issue301
e8d1ebb 
Added import/require example #301
@doug-martin doug-martin added the in release When a feature is merged in to the release branch label Dec 20, 2019
@doug-martin doug-martin mentioned this issue Dec 21, 2019
Merged
@doug-martin
Copy link
Contributor Author

Added in README in v3.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doug-martin doug-martin

@dustinsmith1024 dustinsmith1024

Labels
documentation enhancement in release When a feature is merged in to the release branch
Projects
None yet
Milestone
v3.7.0
Development

No branches or pull requests
2 participants
@doug-martin @dustinsmith1024