C2DEVEL-12313: add verify False flag for as and eks #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszakharov
suggested changes
Aug 11, 2022
c2client/shell.py
Outdated
Comment on lines
34
to
41
| session = boto3.Session( | ||
| aws_access_key_id=aws_access_key_id, | ||
| aws_secret_access_key=aws_secret_access_key, | ||
| region_name="croc", | ||
| ) | ||
|
|
||
| return session.client( | ||
| service, | ||
| endpoint_url=endpoint, | ||
| verify=False, | ||
| ) |
There was a problem hiding this comment.
Если выносить получение клиента в отдельный метод, то нужно за одно избавиться от сессии, сразу создавать клиент.
https://stackoverflow.com/questions/42809096/difference-in-boto3-between-resource-client-and-session
ancient07
force-pushed
the
add-verify-false-to-as-eks
branch
from
2e0deaf to
94a1cc2
Compare
kszakharov
approved these changes
Aug 17, 2022
ancient07
force-pushed
the
add-verify-false-to-as-eks
branch
from
94a1cc2 to
dd7fb70
Compare
refactor verify ssl certificates option, move usage to flag
ancient07
force-pushed
the
add-verify-false-to-as-eks
branch
from
dd7fb70 to
9e82af3
Compare
kszakharov
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.