Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sessions and games so we can have multiplayer #21

Merged
merged 7 commits into from
Sep 7, 2024

Conversation

RolandoDrRobot
Copy link
Contributor

@RolandoDrRobot RolandoDrRobot commented Sep 2, 2024

Closes #20

The idea is to implement the necessary models to have sessions and games where other can join to your game, this was developed in the game jam and was tested there, still need to implement in unity

Included:

  • Tests for the missing models
  • The logic for Game and GamePlayer to support multiplayer functionality, including models with their respective tests and traits, and tests for those traits.
  • The technical debt includes writing the test for the realms.cairo file, even though all the methods it uses are the traits of those new models. Everything should work, but it's more about covering edge cases and simulating the multiplayer session issue. realms.cairo testing cases #30

Testing and Build

Captura de pantalla 2024-09-07 a la(s) 3 02 14 p  m

@coxmars
Copy link
Contributor

coxmars commented Sep 2, 2024

@RolandoDrRobot lgtm, sozo build and sozo test passed. I will review it in more detail tomorrow if you want 🫡

@danielcdz
Copy link
Contributor

In the PR we can use Closes #issue see this comment: #15 (comment)

@danielcdz
Copy link
Contributor

I will review the code in detail tomorrow sir @RolandoDrRobot 🫡

Copy link
Contributor

@coxmars coxmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RolandoDrRobot, LGTM just resolve the conflits and we are done 🫡

@RolandoDrRobot
Copy link
Contributor Author

@coxmars Done 👍

src/models.cairo Outdated Show resolved Hide resolved
src/models/GamePlayer.cairo Outdated Show resolved Hide resolved
src/systems/realms.cairo Show resolved Hide resolved
Copy link
Contributor

@coxmars coxmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts have been resolved, but I'd like to know the responses to Daniel's feedback 🫡

Copy link
Contributor

@coxmars coxmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🫡

Copy link
Contributor

@danielcdz danielcdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RolandoDrRobot RolandoDrRobot merged commit 6746a6c into main Sep 7, 2024
2 checks passed
@jimenezz22 jimenezz22 removed their request for review October 5, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement sessions and games so we can have multiplayer + add missing tests for some models
3 participants