Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize handshakes #144

Open
netgusto opened this issue Aug 22, 2017 · 3 comments
Open

Sanitize handshakes #144

netgusto opened this issue Aug 22, 2017 · 3 comments
Assignees
@netgusto
Milestone
not-now

Comments

@netgusto
Copy link
Member

Handshakes can be sent twice or more, and the server launches the game when the number of HS reaches the expected number of contestants.
@xtuc xtuc added this to the alpha-release milestone Aug 23, 2017
@netgusto
Copy link
Member Author

  • Limit the number of handshakes to 1
  • When accepting the connexion check that the IP of the agent is the same as expected (docker inspect container after spawn)

netgusto pushed a commit that referenced this issue Aug 23, 2017
Issue #144 [WIP]
83ff960
@netgusto
Copy link
Member Author

netgusto commented Aug 23, 2017 •
edited
Loading

Limit the number of handshakes to 1

Done.

When accepting the connexion check that the IP of the agent is the same as expected (docker inspect container after spawn)

Almost implemented, but it seems that the IP we get from docker when inspecting docker is not the same as the IP we get when the client connects via TCP (see 83ff960#diff-dad2ba570e525aca0bb25b71cb24d234R302)

@netgusto
Copy link
Member Author

Shifted to not-now.

@netgusto netgusto modified the milestones: not-now, alpha-release Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netgusto netgusto

Labels
None yet
Projects
None yet
Milestone
not-now
Development

No branches or pull requests
2 participants
@xtuc @netgusto