draft: Check trash path

examples/delete.rs

@@ -0,0 +1,19 @@
+use std::env;
+use std::path::PathBuf;
+use trash::{delete_all, Error};
+
+#[cfg(target_os = "macos")]
+fn main() {
+    println!("This example is not available on macOS");
+}
+
+#[cfg(any(
+    target_os = "windows",
+    all(unix, not(target_os = "macos"), not(target_os = "ios"), not(target_os = "android"))
+))]
+fn main() -> Result<(), Error> {
+    let args: Vec<PathBuf> = env::args().skip(1).map(String::into).collect();
+    delete_all(args)?;
+
+    Ok(())
+}

src/freedesktop.rs

@@ -33,6 +33,27 @@ impl TrashContext {
         let home_topdir = home_topdir(&mount_points)?;
         debug!("The home topdir is {:?}", home_topdir);
         let uid = unsafe { libc::getuid() };
+
+        full_paths.iter().try_for_each(|path| {
+            let topdir = get_topdir_for_path(path, &mount_points);
+
+            if topdir == home_topdir {
+                if path.starts_with(home_trash.as_path()) {
+                    return Err(Error::TargetedTrash);
+                }
+            } else {
+                return execute_on_mounted_trash_folders(uid, topdir, true, true, |trash_path| {
+                    if path.starts_with(trash_path.as_path()) {
+                        Err(Error::TargetedTrash)
+                    } else {
+                        Ok(())
+                    }
+                });
+            }
+
+            Ok(())
+        })?;
+
         for path in full_paths {
             debug!("Deleting {:?}", path);
             let topdir = get_topdir_for_path(&path, &mount_points);
@@ -740,7 +761,7 @@ mod tests {
         env,
         ffi::OsString,
         fmt,
-        fs::File,
+        fs::{remove_dir_all, File},
         os::unix,
         path::{Path, PathBuf},
         process::Command,
@@ -840,6 +861,27 @@ mod tests {
         }
     }
 
+    #[test]
+    #[serial]
+    fn test_delete_trash() {
+        crate::tests::init_logging();
+
+        // don't test in users HOME
+        env::set_var("HOME", env::current_dir().unwrap().canonicalize().unwrap());
+        let home_trash = PathBuf::from("./.local/share/Trash");
+
+        // delete file to generate Trash folder
+        let file_path = get_unique_name();
+        File::create(&file_path).unwrap();
+        delete(&file_path).unwrap();
+
+        // try to delete trash folder
+        assert!(delete(&home_trash) == Err(Error::TargetedTrash));
+
+        // cleanup
+        remove_dir_all(".local").unwrap();
+    }
+
     //////////////////////////////////////////////////////////////////////////////////////
     /// System
     //////////////////////////////////////////////////////////////////////////////////////

src/lib.rs

@@ -132,7 +132,7 @@ where
 }
 
 /// Provides information about an error.
-#[derive(Debug)]
+#[derive(Debug, PartialEq, Eq)]
 pub enum Error {
     Unknown {
         description: String,
@@ -152,6 +152,11 @@ pub enum Error {
     /// and this error is returned, then it's guaranteed that none of the items is removed.
     TargetedRoot,
 
+    /// One of the target items was a trash folder or inside a trash folder.
+    /// If a list of items are requested to be removed by a single function call (e.g. `delete_all`)
+    /// and this error is returned, then it's guaranteed that none of the items is removed.
+    TargetedTrash,
+
     /// The `target` does not exist or the process has insufficient permissions to access it.
     CouldNotAccess {
         target: String,