feat: Short circuiting check for empty trash #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`is_empty()` is a short circuiting function that checks if the trash is empty on Freedesktop compatible systems and Windows. The main purpose of `is_empty()` is to avoid evaluating the entire trash context when the caller is only interested in whether the trash is empty or not. This is especially useful for full trashes with many items.
joshuamegnauth54
force-pushed
the
feat-short-circuiting-is-empty
branch
from
5d44766
to
6d59fa9
Compare
joshuamegnauth54
added a commit
to joshuamegnauth54/cosmic-files
that referenced
this pull request
Oct 16, 2024
Closes: pop-os#310 Depends on Byron/trash-rs#120 which implements a function that only checks if the trash is empty or not instead of parsing each item.
|
+1 |
Byron
approved these changes
Oct 26, 2024
| } | ||
| } | ||
| Err(e) => { | ||
| warn!("The trash files folder {:?} could not be read. Error was {:?}", bin, e); |
There was a problem hiding this comment.
This is an interesting issue - should everything be an error if one folder can't be read?
Right now it assume they are empty even if all of them can't be read.
Unfortunately I don't know if it's common to try to access 'invalid' folders, so I guess we can try to run with this for a while.
|
And here is the new release: https://github.com/Byron/trash-rs/releases/tag/v5.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_empty()is a short circuiting function that checks if the trash is empty on Freedesktop compatible systems and Windows.The main purpose of
is_empty()is to avoid evaluating the entire trash context when the caller is only interested in whether the trash is empty or not. This is especially useful for full trashes with many items.I have to write unit tests, so I'll keep this as a draft till tomorrow or so.