Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plus1 build error #34

Closed
Byron opened this issue Mar 20, 2015 · 4 comments
Closed

plus1 build error #34

Byron opened this issue Mar 20, 2015 · 4 comments
Assignees
@Byron
Milestone
v1.1.0 - Delegate...

Comments

@Byron
Copy link
Owner

Byron commented Mar 20, 2015

illegal recursive struct type; wrap the inner value in a box to make it representable
@Byron Byron added this to the v0.1 - feature completeness milestone Mar 20, 2015
@Byron Byron self-assigned this Mar 20, 2015
@Byron
Copy link
Owner Author

Byron commented Mar 20, 2015

Filed an issue in serde.

Scheduled for review for 1.0, latest.

Byron added a commit that referenced this issue Mar 20, 2015
@Byron
fix(types): make recursive types possible
8d9f175 
Must be `Option<Box<T>>` now, whereas a simple `Box<T>` worked
previously. Anyway, serde can't decode/encode Boxes yet, so
plus1 was removed from the list of APIs to build.

Related to #34
@Byron
Copy link
Owner Author

Byron commented Mar 20, 2015

Also check (for similar reason):

  • civicinfo2
  • discovery1
  • gan1_beta1

@Byron
Copy link
Owner Author

Byron commented Mar 21, 2015

You can watch the development stream on youtube.

Byron added a commit that referenced this issue Mar 21, 2015
@Byron
fix(apis): exclude those with recursive schemas
5ff2285 
They currently don't compile as Box 'serde' is not supported.
See serde-rs/serde#45.

Related to #34.
@Byron
Copy link
Owner Author

Byron commented Apr 7, 2015

serde now supports boxes, all APIs can now build.

@Byron Byron closed this as completed Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Byron Byron

Labels
None yet
Projects
None yet
Milestone
v1.1.0 - Delegate Callbacks
Development

No branches or pull requests
1 participant
@Byron