Skip to content

Commit

Permalink
Remove the xvfb-run again.
Browse files Browse the repository at this point in the history 
It just made it even slower
  • Loading branch information
@ensonic
ensonic committed Feb 16, 2024
1 parent b80d4f9 commit 95aa3f9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- name: make check
id: check
run: |
xvfb-run -- make -k check BT_ARCHIVE_LOGS=1
make -k check BT_ARCHIVE_LOGS=1
- name: Rerun failed tests under gdb and get backtraces
id: rerun_tests
Expand Down

3 comments on commit 95aa3f9

@rffontenelle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ensonic How about splitting tests in different runs (matrix), so the xvfb-run doesn't slow down other tests?

@ensonic
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome idea. Let me see if I can figure this tonight.

@ensonic
Copy link
Member Author

@ensonic ensonic commented on 95aa3f9 Mar 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rffontenelle I've created #153 for it. I also skip the test on CI for now.

Please sign in to comment.