Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test model names to be PascalCase #42

Closed
wants to merge 1 commit into from
Closed

fix: test model names to be PascalCase #42

wants to merge 1 commit into from

Conversation

vlnevyhosteny
Copy link
Contributor

@vlnevyhosteny vlnevyhosteny commented Oct 19, 2023 •
edited
Loading

Closes #22
Closes #21

@vlnevyhosteny vlnevyhosteny mentioned this pull request Oct 19, 2023
Closed
Toreno96
Toreno96 requested changes Oct 20, 2023
View reviewed changes
Copy link

@Toreno96 Toreno96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is PascalCase, not snake_case, tho. Please fix the commit message and PR's title (refactor: test model names to be PascalCase). Apart from that, the PR LGTM.

@vlnevyhosteny vlnevyhosteny changed the title refactor: test model names to be SnakeCase refactor: test model names to be PascalCase Oct 20, 2023
@vlnevyhosteny
Copy link
Contributor Author

This is PascalCase, not snake_case, tho. Please fix the commit message and PR's title (refactor: test model names to be PascalCase). Apart from that, the PR LGTM.

Crap... fixed

Toreno96
Toreno96 approved these changes Oct 23, 2023
View reviewed changes
Copy link

@Toreno96 Toreno96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ViolanteCodes
Copy link
Contributor

@vlnevyhosteny can this be a "fix" in the commit message so that it bumps the version automatically?

@ViolanteCodes ViolanteCodes changed the title refactor: test model names to be PascalCase fix: test model names to be PascalCase Oct 25, 2023
@ViolanteCodes ViolanteCodes mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toreno96 Toreno96 Toreno96 approved these changes

Assignees

@ViolanteCodes ViolanteCodes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply SnakeCaseContractResolver on deserializing pages
3 participants
@vlnevyhosteny @ViolanteCodes @Toreno96