Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the first 16 Ansi256 colors on Windows #10

Merged
merged 2 commits into from
Jun 4, 2019
Merged

Support the first 16 Ansi256 colors on Windows #10

merged 2 commits into from
Jun 4, 2019

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Nov 11, 2018

Fix the issue described in rust-lang/rust#55788 (comment).

This was referenced Nov 12, 2018
Merged
Closed
@mati865
Copy link

mati865 commented Jun 4, 2019

ping @BurntSushi

BurntSushi
BurntSushi requested changes Jun 4, 2019
View reviewed changes
Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a style nit.

src/lib.rs Outdated Show resolved Hide resolved
BurntSushi
BurntSushi approved these changes Jun 4, 2019
View reviewed changes
Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

BurntSushi
BurntSushi requested changes Jun 4, 2019
View reviewed changes
Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed another long line. It's very hard to notice long lines in the diff. Please check to make sure there aren't any more in this diff.

src/lib.rs Outdated Show resolved Hide resolved
@mati865
Copy link

mati865 commented Jun 4, 2019

Maybe you should consider adding rustfmt.toml with max_width setting?

@BurntSushi
Copy link
Owner

BurntSushi commented Jun 4, 2019 •
edited
Loading

@mati865 I'm aware of rustfmt and its ability to enforce a maximum width setting. I've considered using it, several times over the years, but rustfmt is overall not good enough. It makes way too many sub-optimal decisions.

BurntSushi
BurntSushi approved these changes Jun 4, 2019
View reviewed changes
Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BurntSushi BurntSushi merged commit 3beef8b into BurntSushi:master Jun 4, 2019
@BurntSushi
Copy link
Owner

This PR is in termcolor 1.0.5 on crates.io.

@kennytm kennytm deleted the win-ansi-256 branch June 4, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennytm @mati865 @BurntSushi