Avoid running into infinite loops when recovering from Reader errors #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves BurntSushi#207 When reading and parsing a record fails, it's correct behavior in most cases to keep on trying to read and parse the next record. However when the Error is caused by failing to read from the underlying `impl Read`, the next read would almost always fail with the exact same error. In that scenario, reading from the underlying `impl Read` should not be attempted when trying to extract the next record, as this may lead to infinite loops. Instead, the `Reader` will behave in the same way as if an end-of-file had been reached.
Ten0
force-pushed
the
avoid-infinite-loops-on-io-errors
branch
from
86e01ec to
74480e4
Compare
BurntSushi
requested changes
Nov 3, 2020
|
This PR is on crates.io in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #207
When reading and parsing a record fails, it's correct behavior in most cases to keep on trying to read and parse the next record.
However when the Error is caused by failing to read from the underlying
impl Read, the next read would almost always fail with the exact same error.In that scenario, reading from the underlying
impl Readshould not be attempted when trying to extract the next record, as this may lead to infinite loops.Instead, the
Readerwill behave in the same way as if an end-of-file had been reached.