Add -d as short command for --max-depth #2644
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've given a go to #2643, partly just as an experiment into how easy it would be - the answer was pretty easy with the tools available.
I've not:
--max-count / -m
while making this change, where it's exclusively referred to by the long name--max-depth
functionality is tested anywhere, so I didn't see anywhere to add or tweak for the short form. I can add some if you would likeI have given my best go at updating the zsh completions, but I'd be lying if I said I understood exactly how it worked. I've followed the example of
--max-count
and--max-columns
, but I'd appreciate your eye to make sure it's been implemented correctly.I've also tested locally, and it seems to work the same as
--max-depth
does:If you agree with the premise of the change, let me know if there is anything I should update or check for.
Thanks!