New option: Stop on non-match after a match #1930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardopirovano
force-pushed
the
stop-first-nonmatch
branch
from
3dcf3e0 to
ee576d3
Compare
|
Hi @BurntSushi! No particular rush, but just checking you've seen this PR? Let me know if there's any changes you'd like me to make 🙂 |
|
No, I haven't looked at it yet. Unfortunately, my time is very limited and I tend to do PR reviews in batches in order to minimize context switching. It might be a while. |
lespea
reviewed
Aug 17, 2021
| @@ -319,6 +319,7 @@ _rg() { | |||
| '(-q --quiet)'{-q,--quiet}'[suppress normal output]' | |||
| '--regex-size-limit=[specify upper size limit of compiled regex]:regex size (bytes)' | |||
| '*'{-u,--unrestricted}'[reduce level of "smart" searching]' | |||
| '--stop-on-nonmatch[stop on first non-matching line after a matching one]' | |||
There was a problem hiding this comment.
Isn't this missing the = sign like the rest of them?
There was a problem hiding this comment.
No. The = sign is only used for flags that accept an argument.
BurntSushi
added
the
rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1790
This implements the option suggested in the linked issue. In particular, it adds a
--stop-on-nonmatchflag that will stop reading a file once a non-matching line is found after a matching one. This is useful if, for example, a sorted file is being searched and the pattern being matched on is at the start of the line (so it is expected all matches will be adjacent).