deb package is missing completions

[muendelezaji]

What version of ripgrep are you using?

ripgrep 0.9.0 (rev e86d3d9)
-SIMD -AVX

How did you install ripgrep?

ripgrep_0.9.0_amd64.deb

What operating system are you using ripgrep on?

Ubuntu 16.04

Describe your question, feature request, or bug.

Thanks for the fix to #842 to which this is somewhat related. Commit 5c80e4a does not add completion files for bash, zsh etc. to the deb package. I understand this was committed after the 0.9.0 release, but as it stands the next release will still lack these completion files, despite this FAQ entry suggesting otherwise.

Is there a plan to add them to the deb build or should we settle for downloading the release tar & manually copying them to the appropriate location?

[BurntSushi]

@muendelezaji Ah thanks for noticing this! In theory, it should be fairly straight-forward to add completions. You can see how we manage the existing assets here:

ripgrep/Cargo.toml

Lines 89 to 102 in 3edeeca

	assets = [
	["target/release/rg", "usr/bin/", "755"],
	["COPYING", "usr/share/doc/ripgrep/", "644"],
	["LICENSE-MIT", "usr/share/doc/ripgrep/", "644"],
	["UNLICENSE", "usr/share/doc/ripgrep/", "644"],
	["CHANGELOG.md", "usr/share/doc/ripgrep/CHANGELOG", "644"],
	["README.md", "usr/share/doc/ripgrep/README", "644"],
	["FAQ.md", "usr/share/doc/ripgrep/FAQ", "644"],
	# The man page is automatically generated by ripgrep's build process, so
	# this file isn't actually commited. Instead, to create a dpkg, either
	# create a deployment directory and copy the man page to it, or use the
	# 'ci/build_deb.sh' script.
	["deployment/rg.1", "usr/share/man/man1/rg.1", "644"],
	]

I think the only thing I really need to know here is where to put the completions themselves. They probably vary by shell and I'm not familiar with Debian's convention here.

[okdana]

zsh completion functions for Debian/Ubuntu packages belong in /usr/share/zsh/vendor-completions.

I think bash completion functions are supposed to go in /usr/share/bash-completion/completions, but i'm less sure of the conventions there. Some packages also add them to /etc/bash_completion.d, idk.

Not sure about fish at all, but a quick glance at the package contents suggests /usr/share/fish/completions.