-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerize #223
base: master
Are you sure you want to change the base?
Dockerize #223
Conversation
I have used Docker before, but I am not quite sure about your question. Can you please explain a little more about your issue? |
depends_on: | ||
- "postgres" | ||
restart: always | ||
command: ['./install/wait-for-postgres.sh', 'postgres', './scripts/nfldb-update', '--interval', '60' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhavik3jain my question was related to this line. I was asking if this is a good default command to have for nfldb-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally think it would be a great idea to have that as a command. Mainly because when someone is able to start up their docker image, they will have the most up to date values for their nfldb
Also another question for you, I don't remember this, but can I set this to point to a different database, meaning I have a database hosted on AWS, I should be able to point it to that right? |
Not for the proposed First you would need to edit the |
An initial pass at Docker and docker compose for #48
I haven't really used nfldb before so some pointers as to what a sane default command in the
docker-compose.yml
should be would be great.