Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize #223

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Dockerize #223

wants to merge 4 commits into from

Conversation

jfyne
Copy link

@jfyne jfyne commented Jan 16, 2017

An initial pass at Docker and docker compose for #48

I haven't really used nfldb before so some pointers as to what a sane default command in the docker-compose.yml should be would be great.

@bhavik3jain
Copy link

I have used Docker before, but I am not quite sure about your question. Can you please explain a little more about your issue?

depends_on:
- "postgres"
restart: always
command: ['./install/wait-for-postgres.sh', 'postgres', './scripts/nfldb-update', '--interval', '60' ]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhavik3jain my question was related to this line. I was asking if this is a good default command to have for nfldb-update

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think it would be a great idea to have that as a command. Mainly because when someone is able to start up their docker image, they will have the most up to date values for their nfldb

@bhavik3jain
Copy link

Also another question for you, I don't remember this, but can I set this to point to a different database, meaning I have a database hosted on AWS, I should be able to point it to that right?

@jfyne
Copy link
Author

jfyne commented Jan 21, 2017

Not for the proposed docker-compose.yml. As long as your AWS hosted database is postgres compatible the Dockerfile can be used to connect to that instead.

First you would need to edit the install/config.ini to point to your AWS setup. Then you would need to build the Dockerfile and then run the container. This will not do the automatic install of the default data though, as this is done in the postgres image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants