You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm maintaining the Fedora Linux package for this crate, and upon the update from v0.7 to v1.0, I see new test failure on 32-bit x86 (i.e. i686-unknown-linux-gnu) related to AhoCorasick::memory_usage:
The failure itself looks harmless (i.e. the memory usage is lower than the expected one, which isn't unexpected on 32-bit systems (as types like usize / isize etc. are half the size on i686 than they are on x86_64), but I wanted to report this nonetheless.
For now I'm going to ignore these tests on 32-bit systems, but maybe it might make sense to make the comparison <= expected instead of ==expected, or to gate the assertions in the AhoCorasick::memory_usage doctest with #[cfg(target_pointer_width = "64")]?
The text was updated successfully, but these errors were encountered:
I'm maintaining the Fedora Linux package for this crate, and upon the update from v0.7 to v1.0, I see new test failure on 32-bit x86 (i.e. i686-unknown-linux-gnu) related to
AhoCorasick::memory_usage
:The failure itself looks harmless (i.e. the memory usage is lower than the expected one, which isn't unexpected on 32-bit systems (as types like
usize
/isize
etc. are half the size on i686 than they are on x86_64), but I wanted to report this nonetheless.For now I'm going to ignore these tests on 32-bit systems, but maybe it might make sense to make the comparison
<= expected
instead of==expected
, or to gate the assertions in theAhoCorasick::memory_usage
doctest with#[cfg(target_pointer_width = "64")]
?The text was updated successfully, but these errors were encountered: