Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: s3 symsrv support #66

Merged
merged 6 commits into from
Oct 9, 2023
Merged

feat: s3 symsrv support #66

merged 6 commits into from
Oct 9, 2023

Conversation

bobbyg603
Copy link
Member

@bobbyg603 bobbyg603 commented Oct 6, 2023 •
edited
Loading

TODO

Description

Upload .pdb, .dll, and .exe files with guids to our new s3 symsrv location.

I also fixed an issue where a stream was getting destroyed by garbage collection instead of explicitly destroyed which may fix #61

Resolves #65

Checklist

  • Tested manually
  • Unit tests pass with no errors or warnings
  • Documentation updated (if applicable)
  • Reviewed by at least 1 other contributor

@bobbyg603 bobbyg603 marked this pull request as draft October 6, 2023 15:33
@bobbyg603 bobbyg603 changed the title feat: s3 symserv support feat: s3 symsrv support Oct 9, 2023
@bobbyg603 bobbyg603 marked this pull request as ready for review October 9, 2023 14:55
@bobbyg603 bobbyg603 merged commit b41726d into main Oct 9, 2023
@bobbyg603 bobbyg603 deleted the symserv branch October 9, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveplunkett daveplunkett daveplunkett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bobbyg603 @daveplunkett