Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error ENOTEMPTY deleting tmp #63

Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix: error ENOTEMPTY deleting tmp #63

merged 1 commit into from
Oct 2, 2023

Conversation

bobbyg603
Copy link
Member

@bobbyg603 bobbyg603 commented Sep 29, 2023 •
edited
Loading

We know that the Windows file system can be super sus and hang on to files. This change does the following:

  • Ensures that we release the handle on tmpZipFile when there's an error
  • Retries deleting the tmp directory with an exponential backoff

Fixes #60

@bobbyg603 bobbyg603 changed the title fix: error: ENOTEMPTY: directory not empty, rmdir 'C:\[...]\tmp' fix: error: ENOTEMPTY: directory not empty Sep 29, 2023
@bobbyg603 bobbyg603 changed the title fix: error: ENOTEMPTY: directory not empty fix: error ENOTEMPTY deleting tmp Sep 29, 2023
@bobbyg603 bobbyg603 merged commit cd88e63 into main Oct 2, 2023
@bobbyg603 bobbyg603 deleted the bobbyg603/issue60 branch October 2, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveplunkett daveplunkett daveplunkett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: ENOTEMPTY: directory not empty, rmdir 'C:\[...]\tmp'
2 participants
@bobbyg603 @daveplunkett