Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: require node 22 #130

Merged
merged 1 commit into from
Jul 10, 2024
Merged

chore: require node 22 #130

merged 1 commit into from
Jul 10, 2024

Conversation

bobbyg603
Copy link
Member

@bobbyg603 bobbyg603 commented Jul 10, 2024

Description

Didn't realize we broke Second Life by going to node 22. Doing a major version rev to reflect the breaking change.

Now customers get a warning:

bobby@Mr-Presidents-MacBook-Pro symbol-upload % npm i
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@bugsplat/[email protected]',
npm WARN EBADENGINE   required: { node: '>=22' },
npm WARN EBADENGINE   current: { node: 'v20.11.1', npm: '10.2.4' }
npm WARN EBADENGINE }

Checklist

  • Tested manually
  • Unit tests pass with no errors or warnings
  • Documentation updated (if applicable)
  • Reviewed by at least 1 other contributor

BREAKING CHANGE: node sea requires node 22 or newer
@bobbyg603 bobbyg603 merged commit a16e9be into main Jul 10, 2024
5 checks passed
@bobbyg603 bobbyg603 deleted the 22 branch July 10, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants