Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: symbol-upload-linux fails if tmp dir doesn't exist #128

Merged
merged 3 commits into from
Jul 9, 2024
Merged

fix: symbol-upload-linux fails if tmp dir doesn't exist #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89412ba
fix: symbol-upload-linux fails if tmp dir doesn't exist
bobbyg603 Jul 5, 2024
d719e41
fix: signtool for github action runners
bobbyg603 Jul 5, 2024
90ed418
fix: windows signature removal
bobbyg603 Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bin/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import { ApiClient, BugSplatApiClient, OAuthClientCredentialsClient, VersionsApi
import commandLineArgs, { CommandLineOptions } from 'command-line-args';
import commandLineUsage from 'command-line-usage';
import { glob } from 'glob';
import { existsSync } from 'node:fs';
import { existsSync, mkdirSync } from 'node:fs';
import { mkdir, readFile, stat } from 'node:fs/promises';
import { basename, extname, join } from 'node:path';
import { basename, dirname, extname, join } from 'node:path';
import { importNodeDumpSyms } from '../src/preload';
import { safeRemoveTmp, tmpDir } from '../src/tmp';
import { uploadSymbolFiles } from '../src/upload';
Expand Down Expand Up @@ -114,6 +114,7 @@ import { CommandLineDefinition, argDefinitions, usageDefinitions } from './comma
symbolFilePaths = symbolFilePaths.map(file => {
console.log(`Dumping syms for ${file}...`);
const symFile = join(tmpDir, `${getSymFileBaseName(file)}.sym`);
mkdirSync(dirname(symFile), { recursive: true });
nodeDumpSyms(file, symFile);
return symFile;
});
Expand Down
4 changes: 2 additions & 2 deletions sea/windows.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
node --experimental-sea-config sea-config.json
node -e "require('fs').copyFileSync(process.execPath, '.\\dist\\symbol-upload-windows.exe')"
signtool remove /s .\dist\symbol-upload-windows.exe
$signtool = "C:\Program Files (x86)\Windows Kits\10\bin\10.0.22621.0\x64\signtool.exe"
& $signtool remove /s ".\dist\symbol-upload-windows.exe"
npx postject .\dist\symbol-upload-windows.exe NODE_SEA_BLOB .\dist\sea-prep.blob --sentinel-fuse NODE_SEA_FUSE_fce680ab2cc467b6e072b8b5df1996b2
#signtool sign /fd SHA256 symbol-upload-windows.exe
Loading