Skip to content

Commit

Permalink
fix: node-dump-syms install step (#139)
Browse files Browse the repository at this point in the history
* chore: update README.md

* chore: update pr action to checkout v4

* chore: update action to default to node-22

* fix: node-dump-syms install script
  • Loading branch information
bobbyg603 authored Sep 12, 2024
1 parent 8dd47cd commit cbf676c
Show file tree
Hide file tree
Showing 6 changed files with 1,113 additions and 4,154 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
os: [ubuntu-latest, macos-latest, windows-latest]
steps:
- name: ☑️ Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: 📦 Symbols
uses: ./
Expand Down
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ Use the `symbol-upload` action in your [GitHub Actions](https://github.com/featu
version: "your-version"
files: "**/*.{pdb,exe,dll}"
directory: "your-build-directory"
node-version: "20"
node-version: "22"
dumpSyms: false
```
Be sure to use [secrets](https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions) so that you don't expose the values for `clientId`, `clientSecret`, and `database`.
Expand All @@ -45,7 +46,7 @@ Be sure to use [secrets](https://docs.github.com/en/actions/security-guides/usin
```bash
bobby@BugSplat % ~ % symbol-upload -h
@bugsplat/symbol-upload v7.2.2
@bugsplat/symbol-upload v10.1.0
symbol-upload contains a command line utility and a set of libraries to help
you upload symbol files to BugSplat.
Expand Down
2 changes: 1 addition & 1 deletion action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ inputs:
description: "Node.js version to use"
type: string
required: false
default: '20'
default: '22'
dumpSyms:
description: "Use dumpSyms to generate symbols"
type: boolean
Expand Down
Loading

0 comments on commit cbf676c

Please sign in to comment.