Add await when processing header to avoid unhandleRejection #698 #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an await missing in the call to the
_processHeaderRow
function that would cause anunhandledRejection
error when any error was encountered. The side effect of this is that theunhandledRejection
error goes under the radar and results in auncaughtException
error that kills the Budibase server.To reproduce
Our koa app also needs a modification to better handle the unhandledRejection