Convert screen store #15408
Convert screen store #15408
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
| @@ -138,13 +148,6 @@ export class ScreenStore extends BudiStore { | |||
| } | |||
|
|
|||
| const definition = componentStore.getDefinition(component._component) | |||
| // Reset whitelist for direct children | |||
| legalDirectChildren = [] | |||
There was a problem hiding this comment.
I cannot see this being referenced anywhere. I assume is safe to remove. Could you confirm, @aptkingston ?
There was a problem hiding this comment.
I think we added this for a certain component but then either removed that component or removed the restriction. It's technically a valid key to add to a component manifest, and I can't guarantee that plugin authors aren't using it, but you're right that we don't currently use it for any of our own components.
I reckon it's fine to delete it.
|
Dean already has a PR up for the screen store, so I'll let you 2 work out what's the best way to go haha. #15313 |
Description
Converting screen store to ts as a ground work for the screen component setting validations. This required the history store and utils to be typed as well.