Fix query rows step when querying a table containing spaces in the name #15346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be encoded. The CTX expects this to be passed in its decoded state as Koa would do to encoded URLs.
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
samwho
reviewed
Jan 13, 2025
| const ctx = buildCtx(appId, null, { | ||
| params: { | ||
| tableId, | ||
| tableId: decodeURIComponent(tableId), |
There was a problem hiding this comment.
I'm confused as to why spaces in the name of the table would affect the- ohhhh the ID for external tables encodes the name within it doesn't it?
There was a problem hiding this comment.
Yeap exactly this - external tables the ID is built from the table name today.
samwho
approved these changes
Jan 13, 2025
…tion-query-rows-table-with-spaces
…com:Budibase/budibase into fix/automation-query-rows-table-with-spaces
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating query row to correctly decode the input table Id as it will be encoded. The CTX expects this to be passed in its decoded state as Koa would do to encoded URLs.
Addresses