Typing notification store #15331
Merged
Typing notification store #15331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While QAing, I found an existing issue for apps trying to access pg instances that are not available. On that case the API returns the following response:
The current code, when the errors don't contain a message, it falls back to showing the "error" field. In this case it can be objects, displaying a confusing message to the end user:
While diagnosing the issue, I typed the notification store and the related client stores.
The end result is not ideal, as the server should probably throw a better formatted error, but this makes sure that errors throwned to the client are at least readable:
Launchcontrol
Add a small description in layman's terms of what this PR achieves. This will be used in the release notes.