Convert portal user store to TS #15327
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
| // Update quotas after any add or remove operation | ||
| this.create = this.refreshUsage(this.create) | ||
| this.save = this.refreshUsage(this.save) | ||
| this.delete = this.refreshUsage(this.delete) | ||
| this.bulkDelete = this.refreshUsage(this.bulkDelete) |
There was a problem hiding this comment.
I would worry that this method of implementing quota updates is quite confusing. I can envision myself reading each of these implementations, having not seen this constructor, and believing we may have a bug where we're not updating quota.
It's repetitive and a bit lame, but putting the quota refresh inline in each of these functions would lead to easier to understand code.
There was a problem hiding this comment.
Yea that's fair. I did a straight copy of the old code (and probably wouldn't have implemented this way from scratch), but I'll refactor it in the interest of readability.
|
Don't merge yet - small change needed. |
aptkingston
added
the
do not merge
…se into type-portal-user-store-2
aptkingston
removed
the
do not merge
Description
Convert portal user store to TS.