Typing grid datasources store #15229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
github-actions
bot
added
firestorm
adrinr
commented
Dec 20, 2024
| @@ -44,20 +45,36 @@ const DependencyOrderedStores = [ | |||
| Users, | |||
| Menu, | |||
| Pagination, | |||
| Config, | |||
| Config as any, | |||
There was a problem hiding this comment.
This needs to be typed as any for now, as we have some conflicts with the outputting types. It will be refactored when all the grid stores are typed
packages/frontend-core/src/components/grid/stores/datasources/viewV2.ts
Outdated
Show resolved
Hide resolved
packages/frontend-core/src/components/grid/stores/datasources/table.ts
Outdated
Show resolved
Hide resolved
packages/frontend-core/src/components/grid/stores/datasources/nonPlus.ts
Outdated
Show resolved
Hide resolved
mike12345567
approved these changes
Dec 20, 2024
adrinr
force-pushed
the
typing/stores-grid-datasources
branch
from
09b1dea to
7b130c7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Typing grid datasources store