Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing automation store #15227

Merged
merged 14 commits into from
Dec 24, 2024
Merged

Typing automation store #15227

merged 14 commits into from
Dec 24, 2024

Conversation

PClmnt
Copy link
Collaborator

@PClmnt PClmnt commented Dec 20, 2024

Description

Types the automation store. There are still quite a few any in here but I thought I'd get the PR up

@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Dec 20, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/l labels Dec 20, 2024
@PClmnt PClmnt requested a review from a team as a code owner December 20, 2024 14:54
@PClmnt PClmnt requested review from adrinr and removed request for a team December 20, 2024 14:54
adrinr
adrinr reviewed Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@adrinr adrinr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added a few comments

packages/builder/src/dataBinding.js Show resolved Hide resolved
packages/builder/src/stores/builder/automations.ts Outdated Show resolved Hide resolved
packages/builder/src/stores/builder/automations.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/xl and removed size/l labels Dec 24, 2024
adrinr
adrinr approved these changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@adrinr adrinr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@PClmnt PClmnt merged commit 98e31c4 into master Dec 24, 2024
20 checks passed
@PClmnt PClmnt deleted the feat/automation-store-ts-conversion branch December 24, 2024 10:29
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mike12345567 mike12345567 mike12345567 left review comments

@adrinr adrinr adrinr approved these changes

Assignees
No one assigned
Labels
firestorm Data/Infra/Revenue Team size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PClmnt @mike12345567 @adrinr