Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing viewV2 store #15224

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Typing viewV2 store #15224

merged 5 commits into from
Dec 20, 2024

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Dec 20, 2024

Description

Typing viewV2 store

@adrinr adrinr requested a review from a team as a code owner December 20, 2024 09:07
@adrinr adrinr requested review from mike12345567 and removed request for a team December 20, 2024 09:07
Copy link

qa-wolf bot commented Dec 20, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/m labels Dec 20, 2024
@adrinr adrinr requested a review from PClmnt December 20, 2024 10:47
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice use of type predicates!

Base automatically changed from typing/stores-table to master December 20, 2024 11:24
@adrinr adrinr enabled auto-merge December 20, 2024 11:24
@adrinr adrinr merged commit 8c0c765 into master Dec 20, 2024
20 checks passed
@adrinr adrinr deleted the typing/stores-viewv2 branch December 20, 2024 11:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants