Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject plugins when importing apps #15196

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

mike12345567
Copy link
Collaborator

Description

Fixing an issue where plugins are imported as apps, which can crash the service - return a useful message to tell the user this is a plugin not an app export.

Addresses: #14977

…he service - return a useful message to tell the user this is a plugin not an app export.
@mike12345567 mike12345567 self-assigned this Dec 17, 2024
@mike12345567 mike12345567 requested a review from a team as a code owner December 17, 2024 13:13
@mike12345567 mike12345567 requested review from adrinr and removed request for a team December 17, 2024 13:13
Copy link

qa-wolf bot commented Dec 17, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/s labels Dec 17, 2024
@mike12345567 mike12345567 merged commit 1b6f113 into master Dec 17, 2024
20 checks passed
@mike12345567 mike12345567 deleted the fix/disallow-plugin-app-import branch December 17, 2024 13:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants