Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stopped containers #15191

Merged
merged 12 commits into from
Dec 17, 2024
Merged

Conversation

mike12345567
Copy link
Collaborator

@mike12345567 mike12345567 commented Dec 16, 2024

Description

Bringing back the old mechanism of removing stopped containers.

This was added in: #15089
Then removed in: 04cb51e

We are having issues with stopped containers blocking tests from running so attempting to add this back in.

Failure example: https://github.com/Budibase/budibase/actions/runs/12355464244/job/34486039531

Following issue seems related: testcontainers/testcontainers-node#881

Solution (temporary)

For anyone following the issue above/experiencing the same issue - the eventual problem/solution was that Github has started rolling out ubuntu-latest to 24.04 from 22.04. For some reason on this new version of Ubuntu test containers fails to find the images by hash, attempting to re-create them continuously eventually leading to test failure.

For now we have switched from running our Github runners on ubuntu-latest to ubuntu-22.04 as this gets us up and running, while we investigate the issues with test containers.

References:

  1. Github begins rollout of new images on the 5th of December - Ubuntu-latest workflows will use Ubuntu-24.04 image actions/runner-images#10636
  2. Release of new image actually occurs on 12th of December - https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20241211.1
  3. Last successful CI run operating on Ubuntu 22.04 - https://github.com/Budibase/budibase/actions/runs/12320310076/job/34389276222
    image
  4. First failing CI run operating on Ubuntu 24.04 - https://github.com/Budibase/budibase/actions/runs/12355464244/job/34486039531
    image

@mike12345567 mike12345567 self-assigned this Dec 16, 2024
@mike12345567 mike12345567 requested a review from a team as a code owner December 16, 2024 17:53
@mike12345567 mike12345567 requested review from adrinr and removed request for a team December 16, 2024 17:53
Copy link

qa-wolf bot commented Dec 16, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/s labels Dec 16, 2024
Copy link
Collaborator

@adrinr adrinr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good finding!

@adrinr adrinr merged commit fc38a46 into master Dec 17, 2024
20 checks passed
@adrinr adrinr deleted the fix/bring-back-remove-stopped-container branch December 17, 2024 07:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants