-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stopped containers #15191
Merged
Merged
Remove stopped containers #15191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good finding!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bringing back the old mechanism of removing stopped containers.
This was added in: #15089
Then removed in: 04cb51e
We are having issues with stopped containers blocking tests from running so attempting to add this back in.
Failure example: https://github.com/Budibase/budibase/actions/runs/12355464244/job/34486039531
Following issue seems related: testcontainers/testcontainers-node#881
Solution (temporary)
For anyone following the issue above/experiencing the same issue - the eventual problem/solution was that Github has started rolling out
ubuntu-latest
to 24.04 from 22.04. For some reason on this new version of Ubuntu test containers fails to find the images by hash, attempting to re-create them continuously eventually leading to test failure.For now we have switched from running our Github runners on
ubuntu-latest
toubuntu-22.04
as this gets us up and running, while we investigate the issues with test containers.References: