Only select required columns from sql databases #15169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
force-pushed
the
BUDI-8885/only-select-required-columns-from-sql-databases
branch
from
4fb5f8c to
da92c3b
Compare
adrinr
changed the title
adrinr
force-pushed
the
BUDI-8885/only-select-required-columns-from-sql-databases
branch
from
2bfcb11 to
7f3b73f
Compare
Base automatically changed from
chore/guard-display-column-in-the-api
to
master
December 19, 2024 11:30
adrinr
added
the
do not merge
| @@ -86,7 +89,7 @@ export async function patch(ctx: UserCtx<PatchRowRequest, PatchRowResponse>) { | |||
| // The id might have been changed, so the refetching would fail. Recalculating the id just in case | |||
| const updatedId = | |||
| generateIdForRow({ ...beforeRow, ...dataToUpdate }, table) || _id | |||
| const row = await sdk.rows.external.getRow(table._id!, updatedId, { | |||
| const row = await sdk.rows.external.getRow(sourceId, updatedId, { | |||
| fields = extractRealFields(table) | ||
| } | ||
|
|
||
| if (!isView || !helpers.views.isCalculationView(source)) { |
There was a problem hiding this comment.
For calculation views, I assume this ends up just leaving the fields empty (since its up to the SQL layer to generate the select statements for these)
mike12345567
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Edit the SQL generation (for both external and sqs) in order to not include
select *. Instead, pull only the required fields. This applies both on the requested table rows plus the linked relationships. This change will increase performance, not pulling non-needed data.There is an exception for this when there is a formula field on the requested fields. Given that this formula might use other columns, we need to pull it all in order to compute them.
Launchcontrol
Smarter SQL select, requesting only the required data.