Ai fixes #14918
Merged
Ai fixes #14918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shogunpurple
requested review from
mike12345567
and removed request for
a team
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
samwho
approved these changes
Oct 30, 2024
adrinr
reviewed
Oct 31, 2024
| @@ -216,10 +216,6 @@ export async function inputProcessing( | |||
| if (field.type === FieldType.FORMULA) { | |||
| delete clonedRow[key] | |||
| } | |||
| // remove any AI values, they are to be generated | |||
There was a problem hiding this comment.
Why this? Do we want to persist/analyse these imports?
There was a problem hiding this comment.
As I understood it, this was the thing stripping AI column results when doing a bulk import.
There was a problem hiding this comment.
that's it - when you re-import a CSV that has AI columns they were being stripped. We don't want to make the user generate them again, unless they specifically click to do so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some fixes for the AI functionality for v3. Importing an AI field from a table import caused empty values to be written, and the AI column functionality was not correctly wired up to our posthog feature flagging system.
Addresses