Allow calculation views to hide required fields. #14720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aptkingston
approved these changes
Oct 7, 2024
samwho
requested review from
aptkingston and
adrinr
and removed request for
mike12345567
adrinr
requested changes
Oct 7, 2024
adrinr
approved these changes
Oct 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was raised by @aptkingston while implementing the frontend for this feature. When we return a view from the views API, all of the table fields that are not present on the view are "enriched" onto it but set to
visible: false. So when making modifications to the view, the update request sent will include these invisible fields.We need to support calculation views being allowed to hide required fields, which I believe is okay because rows cannot be written to calculation views.