Fix SQS error handling. #14717
Merged
Fix SQS error handling. #14717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinr
approved these changes
Oct 7, 2024
| if (response.status > 300) { | ||
| throw json | ||
| if (response.status >= 300) { | ||
| const text = await response.text() |
There was a problem hiding this comment.
Correct me if I'm wrong but I thought .text() just got the plain old body contents without trying to parse it, so I thought it was always safe to use.
…qs-5xx-error-handling
…qs-5xx-error-handling
…qs-5xx-error-handling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were attempting to parse the body as JSON before we knew it was JSON, resulting in parse failures before the error handling could kick in.