Make sure calculation views are created and returned correctly from the API. #14681
Conversation
…red are not required on the view.
samwho
changed the title
samwho
requested review from
mike12345567 and
adrinr
and removed request for
a team
| if (helpers.views.isCalculationField(viewSchema[key])) { | ||
| return viewSchema[key].visible !== false | ||
| } | ||
| return key in tableSchema && tableSchema[key].visible !== false |
There was a problem hiding this comment.
Is this not bypassing the view visibility?
There was a problem hiding this comment.
I broke some tests while working on this and the current state of the code passes the various visibility tests I broke. I haven't changed any visibility tests. In what way would this break view visibility?
There was a problem hiding this comment.
Interesting... Good we have tests for this. I were just worried that we do const visibleFields = new Set([...visibleSchemaFields, ...visibleTableFields]), including the table fields. It might be trimmed in some post-process then
… into view-calculation-sql-4
| if (helpers.views.isCalculationField(viewSchema[key])) { | ||
| return viewSchema[key].visible !== false | ||
| } | ||
| return key in tableSchema && tableSchema[key].visible !== false |
There was a problem hiding this comment.
Interesting... Good we have tests for this. I were just worried that we do const visibleFields = new Set([...visibleSchemaFields, ...visibleTableFields]), including the table fields. It might be trimmed in some post-process then
Description
Adds code and tests to make sure calculation views are treated correctly by the create and get view APIs. Prior to this, calculation fields were being stripped due to not being part of the table schema.