Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more automation tests #14369

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Add more automation tests #14369

merged 6 commits into from
Aug 13, 2024

Conversation

PClmnt
Copy link
Collaborator

@PClmnt PClmnt commented Aug 13, 2024

Description

Adds more automation tests specifically around multiple loops in an automation (which we have had issues with in the past) and external querying and creating rows.

Also updated the output type for looping to be correct.

@PClmnt PClmnt requested a review from a team as a code owner August 13, 2024 10:52
@PClmnt PClmnt requested review from mike12345567 and removed request for a team August 13, 2024 10:52
@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/m labels Aug 13, 2024
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one NAB comment, otherwise these tests are great!

@PClmnt PClmnt merged commit 37f7490 into master Aug 13, 2024
12 checks passed
@PClmnt PClmnt deleted the feat/automation-scenario-tests branch August 13, 2024 13:16
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants