Add Oracle to datasource.spec.ts. #14325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwho
commented
Aug 6, 2024
Comment on lines
-288
to
-290
| constraints: { | ||
| presence: true, | ||
| }, |
There was a problem hiding this comment.
Ended up removing this because when we create the table, we don't set DB-level not-null checks. I'm uncertain why, but adding this here and then having an exclusion for it later on in the objectContaining check seemed weird.
mike12345567
approved these changes
Aug 6, 2024
…bug-when-fetching-tables
samwho
deleted the
budi-8468-oracle-connector-has-a-weird-ui-bug-when-fetching-tables
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Missed this one in the big Oracle PR. Only one change needed to get this to pass, a more strict not-null check. It was sometimes finding nullable columns to be not-null.