Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to delete SSO ID doc as well #14307

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

melohagan
Copy link
Collaborator

Description

When an account is deleted, it correctly removes associated CouchDB docs based on email address, but it was leaving behind the SSO doc.
This has been fixed to make sure that the SSO doc is also deleted.

Launchcontrol

Minor bug fix relating to Microsoft SSO

@melohagan melohagan requested a review from a team as a code owner August 2, 2024 19:14
@melohagan melohagan requested review from mike12345567 and removed request for a team August 2, 2024 19:14
Copy link

linear bot commented Aug 2, 2024

Copy link
Collaborator

@samwho samwho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to get a test for this, to prevent it from regressing in future.

@melohagan melohagan merged commit f07ebc1 into master Aug 5, 2024
12 checks passed
@melohagan melohagan deleted the gro-573-verify-sso-login-microsoft-bug branch August 5, 2024 11:54
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants