Remove global node-fetch mock. #14297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike12345567
reviewed
Aug 2, 2024
| @@ -75,14 +84,9 @@ export async function create(ctx: any) { | |||
| const doc = await pro.plugins.storePlugin(metadata, directory, source) | |||
|
|
|||
| clientAppSocket?.emit("plugins-update", { name, hash: doc.hash }) | |||
| ctx.body = { | |||
There was a problem hiding this comment.
It fell out after I typed the response object.
adrinr
reviewed
Aug 2, 2024
| @@ -75,14 +84,9 @@ export async function create(ctx: any) { | |||
| const doc = await pro.plugins.storePlugin(metadata, directory, source) | |||
|
|
|||
| clientAppSocket?.emit("plugins-update", { name, hash: doc.hash }) | |||
| ctx.body = { | |||
| await config.api.application.delete(app.appId) | ||
| expect(events.app.deleted).toHaveBeenCalledTimes(1) | ||
| expect(events.app.unpublished).toHaveBeenCalledTimes(1) | ||
| }) | ||
|
|
||
| it("should delete published app and dev app with prod app ID", async () => { | ||
| await config.api.application.delete(app.appId.replace("_dev", "")) | ||
| const prodAppId = app.appId.replace("_dev", "") |
There was a problem hiding this comment.
Is this part of the test? It looks like all the tests are doing the same, probably are part of the setup instead
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the global
__mocks__/node-fetch.tsfile inpackages/serverin favour of usingnockwhere needed.Additionally I've set up
nockto disallow any requests to the internet outside of localhost.