Trim couchdb fields while exporting rows #14289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwho
reviewed
Jul 31, 2024
| expect(results.length).toEqual(1) | ||
| const row = results[0] | ||
|
|
||
| expect(Object.keys(row)).toEqual(["_id", "name", "description"]) |
There was a problem hiding this comment.
Does the order matter here? Is Object.keys guaranteed to return the keys in that order? Will the test fail if it changes?
There was a problem hiding this comment.
It matters for the test, but this should not change. It exports by the schema order, so changing the implementation might cause some errors.
samwho
approved these changes
Jul 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when exporting csv rows, we are exporting the full document. This give us fields that are not visible to the user, and they are causing some confusion (specially around reimporting). This only affects internal rows, as it has the extra data.
This PR trims all the fields that are not part of the table schema, but the _id (as it's used for matching when re-importing)
Launchcontrol
Trim couchdb fields on internal table row exports