Improve typings #14281
Merged
Improve typings #14281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinr
commented
Jul 30, 2024
| @@ -102,7 +103,7 @@ describe.each([ | |||
| ): SaveTableRequest { | |||
| const defaultSchema: TableSchema = { | |||
| id: { | |||
| type: FieldType.AUTO, | |||
There was a problem hiding this comment.
The id field is mandatory for external ds, and having it as auto causes conflicts with parallel creations. Having them as number solves that issue and its closer to the real BB use cases
There was a problem hiding this comment.
This is correct anyway - no columns actually have a FieldType.AUTO type.
mike12345567
approved these changes
Jul 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type untyped APIs and improve schema typing