Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save autofields on bulksaves #14280

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Save autofields on bulksaves #14280

merged 6 commits into from
Jul 30, 2024

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Jul 30, 2024

Description

We found an issue when writing some tests due to some inconsistencies between db.put and db.bulkPut.put sets createdAt and updatedAt, but bulkPut does not. This PR ensures that we have consistency between both methods.

Launchcontrol

Persist createdAt and updatedAt on bulkPut

@adrinr adrinr requested a review from a team as a code owner July 30, 2024 15:39
@adrinr adrinr requested review from mike12345567 and removed request for a team July 30, 2024 15:39
@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/m labels Jul 30, 2024
@adrinr adrinr requested a review from samwho July 30, 2024 15:42
@adrinr adrinr merged commit 737b250 into master Jul 30, 2024
12 checks passed
@adrinr adrinr deleted the chore/save_autofields_on_bulksaves branch July 30, 2024 16:52
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mike12345567 mike12345567 mike12345567 approved these changes

@samwho samwho Awaiting requested review from samwho

Assignees
No one assigned
Labels
firestorm Data/Infra/Revenue Team size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrinr @mike12345567