Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce automation store updates and API fetches #14271

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Reduce automation store updates and API fetches #14271

merged 4 commits into from
Jul 30, 2024

Conversation

deanhannigan
Copy link
Contributor

@deanhannigan deanhannigan commented Jul 30, 2024 •
edited
Loading

Description

Routify seemed to lock up and become unresponsive due to the amount of updates being made to the automations store

  • Removed unnecessary fetches from store functions that called the save function. They were fetching automations twice.
  • Tidied up the delete function to squash the number store updates and also clear out automationDisplayData.

Addresses

  • In certain circumstances the builder would lock up and become unresponsive
  • Specifically, if you deleted your last automation, the builder would get stuck in the automation section.

Launchcontrol

Fixes to reduce the number of updates to the automation store.

@deanhannigan
Reduced the number of unnecessary calls to update the automation stor…
cad066c 
…e or fetch automations. The contant updates appeared to cause issues with routify
@deanhannigan deanhannigan requested a review from aptkingston July 30, 2024 09:11
@deanhannigan deanhannigan marked this pull request as draft July 30, 2024 09:23
@deanhannigan deanhannigan marked this pull request as ready for review July 30, 2024 10:10
shogunpurple
shogunpurple approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aptkingston aptkingston enabled auto-merge July 30, 2024 14:04
@aptkingston aptkingston merged commit d1d0eae into master Jul 30, 2024
12 checks passed
@aptkingston aptkingston deleted the dean-fixes branch July 30, 2024 14:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shogunpurple shogunpurple shogunpurple approved these changes

@aptkingston aptkingston aptkingston approved these changes

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deanhannigan @aptkingston @shogunpurple