Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show datasource options for array bindings that lack table IDs #14228

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

aptkingston
Copy link
Member

Description

Fixes an issue where invalid datasources were being listed for data providers. This PR removes any array-like datasources generated from bindings that lack a table ID.

Addresses

Copy link
Contributor

@Ghrehh Ghrehh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aptkingston aptkingston enabled auto-merge July 25, 2024 10:17
@aptkingston aptkingston merged commit 91bc48b into master Jul 25, 2024
12 checks passed
@aptkingston aptkingston deleted the remove-selected-rows-datasource branch July 25, 2024 10:20
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants