Move Role constants from frontend core to shared core #13940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing to mention, the backend also has some cases where this is duplicated, to be honest we could move this to an enumeration in |
samwho
reviewed
Jun 13, 2024
There was a problem hiding this comment.
I see Mike has given some advice on this but I want to quickly note that it's probably best to remove the launchcontrol section of the PR description rather than put "chore" in it. We now strip out empty launchcontrol content in Discord so getting rid of it just removes clutter.
…ub.com/Budibase/budibase into grow-301-move-role-enum-to-shared-core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
Addresses