Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis query command doesn't accept spaced values #12357

Merged

Conversation

melohagan
Copy link
Collaborator

Description

The redis command code was splitting on whitespace, however this didn't factor in phrase values that include spaces. Now matching for string values and excluding them from the token split.
Unit test added.

Addresses

Screenshots

Screenshot 2023-11-09 at 17 02 23

Screenshot 2023-11-09 at 17 02 40

@codecov-commenter
Copy link

Codecov Report

Merging #12357 (1ea35a3) into master (bc5fa27) will increase coverage by 6.69%.
The diff coverage is 100.00%.

❗ Current head 1ea35a3 differs from pull request most recent head 383a60d. Consider uploading reports for the commit 383a60d to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master   #12357      +/-   ##
==========================================
+ Coverage   69.05%   75.74%   +6.69%     
==========================================
  Files         598      338     -260     
  Lines       22208    14206    -8002     
  Branches     4470     2989    -1481     
==========================================
- Hits        15335    10760    -4575     
+ Misses       6359     3218    -3141     
+ Partials      514      228     -286     
Files Coverage Δ
packages/server/src/integrations/redis.ts 79.24% <100.00%> (+1.69%) ⬆️

... and 260 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@melohagan melohagan enabled auto-merge (squash) November 9, 2023 18:13
@melohagan melohagan merged commit b68607b into master Nov 9, 2023
10 checks passed
@melohagan melohagan deleted the budi-6518-redis-query-command-doesnt-accept-spaced-values branch November 9, 2023 18:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants