Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UPDATE_ROW automation step from blanking out link fields if they haven't changed. #12297

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Nov 6, 2023

Description

This bug appears to have been fixed in other changes since it was filed (following up with @PClmnt about that), so in the meantime I've added some tests for this behaviour to make sure it doesn't regress.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

Merging #12297 (f21adde) into master (60123d8) will increase coverage by 6.73%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master   #12297      +/-   ##
==========================================
+ Coverage   69.00%   75.74%   +6.73%     
==========================================
  Files         597      338     -259     
  Lines       22178    14186    -7992     
  Branches     4468     2981    -1487     
==========================================
- Hits        15304    10745    -4559     
+ Misses       6365     3218    -3147     
+ Partials      509      223     -286     
Files Coverage Δ
...es/server/src/automations/tests/utilities/index.ts 91.42% <100.00%> (ø)

... and 259 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@samwho samwho requested a review from mike12345567 November 6, 2023 16:57
@samwho samwho marked this pull request as ready for review November 6, 2023 16:57
@samwho samwho added the firestorm Data/Infra/Revenue Team label Nov 6, 2023
Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samwho samwho merged commit 5033388 into master Nov 6, 2023
10 checks passed
@samwho samwho deleted the bug/budi-7379-update-action-step-removes-previously-set-relationships-if branch November 6, 2023 18:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants