Read only form fields #12244
Merged
Read only form fields #12244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aptkingston
reviewed
Nov 2, 2023
There was a problem hiding this comment.
Nice work @melohagan! Just left one suggestion about how to better handle click events in some of the fields 👍
…ttps://github.com/Budibase/budibase into budi-7105-builder-option-for-read-only-form-fields
shogunpurple
deleted the
budi-7105-builder-option-for-read-only-form-fields
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various form fields now have a setting to make them readonly.
The two exceptions are attachment fields and the code scanner fields which have the same behaviour regardless of whether the parent form is disabled or readonly.
For form blocks, View mode now sets the fields to readonly instead of disabled, as disabled fields are quite difficult to read, however you can override this with the disabled setting if wanted.
If disabled is checked, then the readonly setting will not display.
Addresses:
Screenshots
Screen.Recording.2023-11-01.at.16.47.04.mov
Feature branch env
Feature Branch Link